Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added_function_to_manage_SDDC_host #115

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Added_function_to_manage_SDDC_host #115

merged 3 commits into from
Dec 15, 2021

Conversation

jain-prerna
Copy link
Contributor

No description provided.

@jain-prerna jain-prerna mentioned this pull request Oct 8, 2021
Open
waynew
waynew suggested changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some tests are missing here, otherwise I didn't notice anything that needs to be addressed

src/saltext/vmware/modules/vmc_sddc_host.py Show resolved Hide resolved
@jain-prerna
Copy link
Contributor Author

Looks like some tests are missing here, otherwise I didn't notice anything that needs to be addressed

I have added it, please do check now.

@jain-prerna jain-prerna requested a review from waynew December 8, 2021 12:11
waynew
waynew approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@waynew waynew merged commit 12d7359 into saltstack:main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynew waynew waynew approved these changes

@joechainz joechainz Awaiting requested review from joechainz

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jain-prerna @waynew @vmwclabot